>
> The build had been tweaked so the output of configure is processed to
> change "HAVE_WHATEVER" into "LOG4CXX_HAVE_WHATEVER".  That processing
> is no longer needed since we do not include any of the "config*.h" in
> our header files.  Probably would be good to eliminate that extra step
> and switch remaining LOG4CXX_HAVE's to just HAVE.  Could you take a
> look at how to do that.
>
Removing LOG4CXX_xxx in configure.in is easy. Here is the diff for 
configure.in. Should I go through the source-files and change it also?

That's good, that config*.h is not included in the headers any more. This is a 
much better approach. Should config*.h moved to src then? Then the 
include-directory looks the same after installation.

Index: configure.in
===================================================================
RCS file: /home/cvspublic/logging-log4cxx/configure.in,v
retrieving revision 1.46
diff -u -r1.46 configure.in
--- configure.in	26 Dec 2004 07:31:52 -0000	1.46
+++ configure.in	29 Dec 2004 09:02:10 -0000
@@ -18,7 +18,7 @@
 
 AC_SUBST(LT_VERSION)
 
-AC_CONFIG_HEADERS([include/log4cxx/config_auto.h],[cat "${ac_abs_top_builddir}/include/log4cxx/config_auto.h" | sed -e 's/\(HAVE_\|MUST_\|UNICODE\)/LOG4CXX_\1/;s/^\(.*PACKAGE.*\|.*VERSION.*\|.*STDC_HEADERS.*\)$/\/* \1 *\//' > "${ac_abs_top_builddir}/include/log4cxx/config_auto_log4cxx.h"])
+AC_CONFIG_HEADERS([include/log4cxx/config_auto.h])
 
 AH_VERBATIM([HAVE_NO_EXPLICIT_EXPORTS],
 [/* no explicit exports */

Reply via email to