On Dec 30, 2004, at 5:13 PM, Tommi M�kitalo wrote:
Hi,
I just thought about config_msvc.h. I think it would be better to remove it
and replace with autoconf-tests. The idea of autoconf is not to distinquish
compilers, but features. There should be no "#if _MSC_VER <= 1200" or
something, but "#if HAVE_THIS_SPECIAL_FEATURE".
Another point is, that e. g. this macro LOG4CXX_HAVE_OLD_WIN32_INTERLOCKS,
which is defined in config_msvc.h is not used at all, so this is useless
anyway.
The need for LOG4CXX_HAVE_OLD_WIN32_INTERLOCKS and hopefully a lot of the other defines in config_msvc.h and config_auto.h have been eliminated with the migration to APR. When everything is cleaned out, I don't think there will be much remaining that will be that much to be detected.
You have also previously suggested moving config_auto.h into the src directory since it is not needed by client applications. A lot of other files in the include tree are also not needed by client applications, we might suppress those
in the "make install" but I don't think we want to try to move them at this time.
