Le Jeudi 5 Mai 2005 18:06, Curt Arnold a �crit�: > They are both good and intended. log4cxx/log4cxx.h contains typedef > and defines that are visible to applications using log4cxx, > log4cxx/private/log4cxx.h contains typedef and defines that are only > visible to the log4cxx implementation. log4cxx/private/log4cxx.h > contains a #error, if it is used outside of the log4cxx implementation > and test.
Allright. > > I'm not fixed on the names, I would have no problem with > log4cxx/private/log4cxx.h being renamed log4cxx/log4cxx_private.h if > that would make the distinction clearer. It would be clearer indeed, but not that much. > I would think that > log4cxx/log4cxx.h should not contain any automatically detected > settings. Totaly agree on that. > Though it should respond to explicit build instructions > that, for example, change the internal character representation. About this, I have a problem with some ac variables you use in log4cxx.h.in but which are not set by configure.in : LOGCHAR_IS_UTF8 and HAS_WCHAR_T How do you expect them to be defined ? Do I add some option to configure of do I compute it from --enable-unicode ? Regards, Christophe
