Our Gump builds had not been attempted for several days due to a
problem that kept Ant itself from building.
I hadn't remembered that having two header files that have the same
name would trip up the "header-check" target which checks header files
against the Effective C++ guidelines. I renamed
log4cxx/private/log4cxx.h to log4cxx/private/log4cxx_private.h to avoid
this issue. There were several other header-check issues that needed
to be addressed: lack of copy and assignment operators in SMTPAppender
(Eff C++ Item 11), not having apr on the include path (since our public
headers should not include apr headers), and using string.assign in
headers (causes spurious warning when compiling with Eff C++ warnings)
While I was at it, I added macros to log4cxx_private.h, so that log4cxx
can be build for a fixed locale encoding (most likely UTF-8) which can
allow much simpler character encoding/decoding operations.
