On Feb 9, 2008, at 4:30 PM, Jonathan Wakely wrote:
Hi again,
The first attached patch fixes some compiler errors with GCC 4.3 due
to missing includes. See "Header Dependency Cleanup" in
http://gcc.gnu.org/gcc-4.3/porting_to.html
The second fixes warnings with any version of GCC, caused by
initialising members in the wrong order in a constructor initialiser
list. The standard says that memebrs will be initialised in the order
they're declared in the class body, not the order they appear in the
init list, so for clarity's sake the init list should be in the same
order.
Jonathan
<log4cxx-includes.patch><log4cxx-initwarnings.patch>
Both look good.
Could you file a JIRA issue and attach the patches to that.
