Curt -
1. Ok.. I see that I have cpptaskb4... which is what the download section
had available... so checking it out of SVN now, and will try again.
2. In general, I've always adhered to the standard of always leaving off
the last semicolon of the macro. This way I can treat the macro as a
statement and terminate it with a semicolon in the main body of the code.
I started with this a long time ago (late 80's), at the time I believe some
static checking tool would complain about empty statements also, which is
why my employer at the time had a strict coding guideline about macros.
I am not sure that I am qualified to definitely state whether one is better
than the other, but I would say that (in my opinion) you should change the
macro :-)
Renny Koshy
President & CEO
--------------------------------------------
RUBIX Information Technologies, Inc.
www.rubixinfotech.com
Curt Arnold
<[EMAIL PROTECTED]
rg> To
"Log4CXX Dev"
02/24/2008 02:17 <[email protected]>
PM cc
Subject
Please respond to Re: [VOTE] log4cxx 0.10.0 release
"Log4CXX Dev" candidate
<[EMAIL PROTECTED]
ing.apache.org>
On Feb 24, 2008, at 8:56 AM, [EMAIL PROTECTED] wrote:
> Found a couple of issues on Solaris 8 with Sun One Studio:
>
> Issue 1. The "ant" build doesn't work
> ===========================
> It gives errors about nested comments in the project element. I also
> noticed that ant thinks we're trying to build on Windows. The
> command I
> used was:
>
> ant -Dapr.dir=/export/home/renny/apr-1.2.12
> -Dapr-util.dir=/export/home/renny/apr-util-1.2.12 -Dcompiler=CC
> -Ddebug=true
>
> This is with the latest ant.
>
> So... I switched to the autoconf/automake build...
>
If you are getting a message that "comment" is not supported, that
would make me strongly suspect that you did not update cpptasks to rev
158. I had to add a decent number of features to cpptasks to produce
the project files for inclusion in the release. The comments adds a
comment to the generated project files so we can put in our copyright
notice and license.
I've also changed the Ant build options to align them with the ./
configure options, so now the Ant build will take -Dwith-apr. The
options are documented at site/building/ant.html.
> Issue 2. Most of the headers that use LOG4CXX_PTR_DEF have a
> semicolon (;)
> following the invocation of that macro.
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> Unfortunately, Sun Studio sees this as an error, and stops. I fixed
> it by
> running the following command, which removed the semi-colon
> following the
> invocation of the macro. I also noticed that some files already had
> the
> correct usage.
>
> find . -name \*.h|xargs grep -l "PTR_DEF.*;$"| xargs -i -t
> perl -i
> -p -e "s/(PTR_DEF[^;]*);$/\1/" {}
>
> The only one that was missed was smtpappender.h, which apparently
> has lots
> of spaces after the invokation, thereby causing my search/replace to
> fail
> on it (I had not antcipated that). So I manually edited the file:
> src/main/include/log4cxx/net/smtpappender.h
>
Would it be easier to change the macro so that it requires a semi? I
know that doxygen can have problems when it sees what it thinks is a
function call missing a semi (that is one of the diagnostic messages
it produces).
>
> Status:
> =====
> Right now I'm stuck on some locale issues... will keep posting
> updates as I
> have them.
>
> Renny Koshy
> President & CEO
>
