On Mon, Dec 3, 2012 at 7:32 PM, Andrew Lazarus <[email protected]> wrote: > I wanted one go-round of comments before I made it “official” looking.
Makes perfect sense. One thing I would like to know: #ifndef __APPLE__ #error This is a Mac/ioS only file #else What happens if I use this file from windows? I mean, it is a compile time error right? It would be good, if, me thinks. > I have a unit test, too. The problem is that it required my examining the > Apple Console manually for the inserted record. I’ll turn it into an > automated test of some sort—I guess by querying the System Log. Oh yes, it is pretty difficult i think > > On Dec 3, 2012, at 10:29, Christian Grobmeier <[email protected]> wrote: > >> Hi, >> >> they look good to me. >> >> Two questions: >> >> - any specific reason why you are delivering those without svn patch? >> I think you need to do "svn add <filename>" and then they should >> appear in the patch file >> >> - I am not familiar with C/C++. But I see there is something which >> looks like unit tests here: >> http://svn.apache.org/repos/asf/logging/log4cxx/trunk/src/test/cpp/ >> >> Do you think it is a good idea to keep up the tradition with unit testing? >> >> Cheers + Thanks for the work! The files look good to me :-) >> >> Christian >> >> On Mon, Dec 3, 2012 at 7:20 PM, Andrew Lazarus <[email protected]> wrote: >>> I’ve added a .h and .cpp file that are working for me as an appender to the >>> Apple System Log. >>> >> >> >> >> -- >> http://www.grobmeier.de >> https://www.timeandbill.de > -- http://www.grobmeier.de https://www.timeandbill.de
