On Sun, Nov 20, 2016 at 9:39 AM, Thorsten Schöning <tschoen...@am-soft.de> wrote:
> Guten Tag Robert Middleton, > am Sonntag, 20. November 2016 um 03:31 schrieben Sie: > > > So I've started work on converting everything over to smart > > pointers. You can check it out on my github here: > > https://github.com/rm5248/log4cxx-testing/tree/smart_pointers > > Great work. Any tips on how I could easily merge that with a separate > SVN branch? Especially if you keep committing. I guess I'll try > something using the SVN bridge of GitHub... > It depends on how you want to merge it in. If you don't care about the history, just do a 'git diff' to whatever the first commit was, which will essentially squash everything into one diff that you can apply via patch. > > > This uses a quick and dirty mechanism in autotools to switch > > between C++11 and boost.[...] > > You support autotools and one can easily provide the macros > independently, doesn't look that "dirty" to me. > The only thing that it doesn't do is run checks to make sure that either the compiler supports C++11, or if boost is installed; that's the dirty part of it. Ideally it should check to see what is installed and fail if nothing is found in the configure phase. > > > The > > current code assumes that objects have an instanceof() method; why > > this was used instead of dynamic_cast I don't know, but I suspect > > that the reason is to avoid using RTTI information in the first > > place, since that is (relatively) slow. > > My understanding of the codebase is that it was converted mainly > directly from Java and you have instanceof there. > > Mit freundlichen Grüßen, > > Thorsten Schöning > > -- > Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de > AM-SoFT IT-Systeme http://www.AM-SoFT.de/ > > Telefon...........05151- 9468- 55 > Fax...............05151- 9468- 88 > Mobil..............0178-8 9468- 04 > > AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln > AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow > >
