Guten Tag Curt Arnold,
am Dienstag, 8. Juni 2010 um 05:08 schrieben Sie:
> The hex codes were intentional since they would give the expected
> character value even if compiled using a non-ASCII based encoding like EBCDIC.
Isn't this case already handled by the following in logstring.h?
#if LOG4CXX_CHARSET_EBCDIC
#define LOG4CXX_STR(str) log4cxx::helpers::Transcoder::decode(str)
> I'll try to pull the constants out into preprocessor macros and do a little
> #if(__BORLANDC__)
Thanks, that would be great!
We found two changes where not necessary:
Index: D:/Benutzer/tschoening/Eigene
Dateien/Bibliotheken/trunk/C++/log4cxx/src/main/cpp/cacheddateformat.cpp
===================================================================
--- D:/Benutzer/tschoening/Eigene
Dateien/Bibliotheken/trunk/C++/log4cxx/src/main/cpp/cacheddateformat.cpp
(Revision 1278)
+++ D:/Benutzer/tschoening/Eigene
Dateien/Bibliotheken/trunk/C++/log4cxx/src/main/cpp/cacheddateformat.cpp
(Revision 1279)
@@ -42,7 +42,7 @@
/**
* Expected representation of first magic number.
*/
-const LogString CachedDateFormat::magicString1 = LOG4CXX_STR("654");
+const logchar CachedDateFormat::magicString1[] = { 0x36, 0x35, 0x34, 0 };
/**
Index: D:/Benutzer/tschoening/Eigene
Dateien/Bibliotheken/trunk/C++/log4cxx/src/main/include/log4cxx/helpers/cacheddateformat.h
===================================================================
--- D:/Benutzer/tschoening/Eigene
Dateien/Bibliotheken/trunk/C++/log4cxx/src/main/include/log4cxx/helpers/cacheddateformat.h
(Revision 1278)
+++ D:/Benutzer/tschoening/Eigene
Dateien/Bibliotheken/trunk/C++/log4cxx/src/main/include/log4cxx/helpers/cacheddateformat.h
(Revision 1279)
@@ -62,7 +62,7 @@
/**
* Expected representation of first magic number.
*/
- static const LogString magicString1;
+ static const logchar magicString1[];
/**
Mit freundlichen Grüßen,
Thorsten Schöning
--
Thorsten Schöning
AM-SoFT IT-Systeme - Hameln | Potsdam | Leipzig
Telefon: Potsdam: 0331-743881-0
E-Mail: tschoen...@am-soft.de
Web: http://www.am-soft.de
AM-SoFT GmbH IT-Systeme, Konsumhof 1-5, 14482 Potsdam
Amtsgericht Potsdam HRB 21278 P, Geschäftsführer: Andreas Muchow
