I like this change, but it is a very significant one for distributed app
programmers and its effects need to be clearly spelled out in the next
release if they are incorporated. Namely, if app servers span timezones
and logging events are consolidated in one place, then certain precautions
have to be taken:
1. the time zone should be included as part of the time stamp
2. the potential descrepency of various machine clocks should be noted
The org.apache.log4j.examples.appserver package assist with this somewhat
by providing the machine name as an attribute to help explain why entries
made in chronological order don't have times listed in chronological order.
Using the time that a log entry was made rather than using the time the log
event was generated (as it is now) makes some folks uncomfortable (perhaps
due to the few msec delay caused by remote calls). But it does result in a
single clock for timing all the events.
Paul Glezen
IT Specialist
WebSphere Engagement Team
Tel: 818 539 3321
[EMAIL PROTECTED]
Ceki Gülcü <[EMAIL PROTECTED]> on 03/16/2001 12:01:48 AM
Please respond to "LOG4J Developers Mailing List"
<[EMAIL PROTECTED]>
To: "LOG4J Developers Mailing List" <[EMAIL PROTECTED]>
cc:
Subject: Re: [PATCH] for Class DatePatternConverter
Reinhard,
Your patch results in more accurate results. It's also faster. Good patch.
Ceki
At 22:30 15.03.2001 +0100, Reinhard Deschler wrote:
>Hi there,
>
>following is a patch in DatePatternConverter, which formats the event-time
>
>instead of the current time. This makes specially sense, when the events
>
>are put in the CyclicBuffer.
>
>
>
>Greeting
>
>Reinhard Deschler from Germany
>
>--- PatternParser.java Mon Jan 22 10:57:27 2001
>+++ PatternParser.java.patch Thu Mar 15 20:28:07 2001
>@@ -426,7 +426,7 @@
>
> public
> String convert(LoggingEvent event) {
>- date.setTime(System.currentTimeMillis());
>+ date.setTime(event.timeStamp);
> return df.format(date);
> }
> }
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
I hope to see you at my ApacheCon 2001 presentation
entitled "Log4j, A Logging Package for Java".
See http://ApacheCon.Com/2001/US/ for more details.
----
Ceki Gülcü Web: http://qos.ch
av. de Rumine 5 email: [EMAIL PROTECTED] (preferred)
CH-1005 Lausanne [EMAIL PROTECTED]
Switzerland Tel: ++41 21 351 23 15
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
