Sorry Ceki, what I mean is not " ... the design is no clean". What I would like is try to draw it and understand what can we do. I belive that software starts off with a well design state but every time new functionality are tracked on they loose structure. It easier to see in a UML diagram, less in 30,000 lines of code. I've tried to to represent the log4j because I though It could be useful not only for me. >From the point of view of refactoring there are a some issues we could discuss. For example it could be a good idea introduce a facade to provide a single interface and hide future internal changes. Another issue cuold be provide several well defined interface ( with explicit interfaces ) for context management, appender management , logging methods and so on. The AppenderAttachable interface is used for clients pourposes and for internal pourposes so to change the interface means to change two classes. There are a many other things I'm interested to discuss and know your opinion about. Cheers Maurizio ---------- Da: Ceki Gülcü <[EMAIL PROTECTED]> A: LOG4J Developers Mailing List <[EMAIL PROTECTED]> Oggetto: Re: R: Refactoring Data: giovedì 19 aprile 2001 0.40 Maurizio, Just saw the UML diagram. It looks pretty accurate. Thank you for taking the time to represent the log4j architecture in UML. You say that your intention is to refactor in order to obtain a clean design. Although improvements are always welcome, your description suggests that the current design is not clean. What makes you think that? Cheers, Ceki At 22:33 18.04.2001 +0200, you wrote: >Hello Amar, > here is the first version : http://web.tiscalinet.it/mtavern/diagram.htm >Tell me about. > >Maurizio > > >---------- >Da: Amarnath P <[EMAIL PROTECTED]> >A: LOG4J Developers Mailing List <[EMAIL PROTECTED]> >Oggetto: RE: Refactoring >Data: mercoledì 18 aprile 2001 8.01 > >hi, > hi i'm also in the same area that , doing UML Specs. for Log4j... send me >the detials >to me, so that i can be in part of the prepartions, and which is helpful to >continue... > > >cheers, >amar. > >-----Original Message----- >From: Maurizio Taverna [mailto:[EMAIL PROTECTED]] >Sent: Wednesday, April 18, 2001 5:17 AM >To: [EMAIL PROTECTED] >Subject: Refactoring > > >Hello , > I'm actually working with Log4j and I'm doing a UML class diagram of >the >version 1.0.4. >I would like to know if is interesting to speak about some refactoring >activities to make the design more clean. > >Contact me if interested > >Thank you > >Maurizio Taverna > > > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] -- Ceki Gülcü --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] ---------- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]