Ceki Gülcü wrote:
>
> Steven,
>
> I don't know the reason for having the OptionConverter.convertSpecialChars() call.
>If I am not mistaken, the change was made by Anders. Regards, Ceki
Let's not get into mud slinging, but actually, I believe you're
mistaken. The 1.0.4 code had the equivalent call:
protected
void parseParameters(Element elem, OptionHandler oh) {
String name = elem.getAttribute(NAME_ATTR);
String value = elem.getAttribute(VALUE_ATTR);
LogLog.debug("Handling parameter \""+name+ "="+value+'\"');
if(oh instanceof OptionHandler && value != null) {
oh.setOption(name, OptionConverter.convertSpecialChars(value));
}
}
Cheers,
Anders
>
> ps: It breaks support for windows style file names, e.g. "c:\n.log"
>
> At 10:23 30.04.2001 -0400, you wrote:
>
> >Has a defect in that it tries to do special character substitution when the
>characters come from a property. I don't think this is the desired behavior because
>when the property contains a windows path, then the path gets mangled. I have
>attached a patch to org/apache/log4j/xml/DOMConfigurator.java that hopefully resolves
>this issue.
> >
> >Steven Velez
> >Software Engineer
> >alventive
> >678-202-2226
> >
> >
> >465c465
> >< propSetter.setProperty(name, OptionConverter.convertSpecialChars(value));
> >---
> >> propSetter.setProperty(name, value);
> >678a679
> >> value = OptionConverter.convertSpecialChars(value);
>
> --
> Ceki Gülcü
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
