Hi Ceki, I am not familiar with Log4J's threading and synchronization model, so I thought synchronizing would not hurt. But if format() is already guaranteed to be called in a synchronous fashion, then by all means remove the mutex check.
I'm hanging up my Log4J optimization hat for now. Others may want to look at similar optimizations for other format classes. regards, -Andrew Vajoczki Ceki Gülcü wrote: > > Hi Andrew, > > Nice! I'll check in the code asap. > > I don't see a need for synchronizing on previousTimeLock because > layout objects are not shared and can be attached to only one > appender. The doAppend method in AppenderSkeleton is synchronized and > will protect against any threading surprises... > > Does that make sense? Cheers, Ceki _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
