Thanks for the explanation. I was not reading the error report properly. I am going to try it with other files.
At 20:46 26.03.2002 +1100, you wrote: >Actually the error message is saying that the length of the >constructor is longer than 150 lines, which is the default >value. It is not saying that the length of the line 41 is >greater than 80 characters. I can understand the confusion. > >The check is inspired by the excellent book on refactoring >which promotes small methods and constructors. > >Hope this clears things up. > >Cheers, >Oliver > > > -----Original Message----- > > From: Ceki Gulcu [mailto:[EMAIL PROTECTED]] > > Sent: Tuesday, 26 March 2002 20:06 > > To: Log4J Developers List > > Subject: Re: Checkstyle error report > > > > > > > > Line 41 looks good to me. I am dropping the ball. > > > > At 09:58 26.03.2002 +0100, you wrote: > > > > >Hi, > > > > > >Just to let you know I started using checkstyle. Ironically, I get: > > > > > >(1.3.1) EITAN ~/ASF/jakarta-log4j-1.2beta5 >ant checkstyle > > >Buildfile: build.xml > > > > > >init: > > > > > >checkstyle: > > >[checkstyle] Starting audit... > > >[checkstyle] > > >C:\home\cgu\ASF\jakarta-log4j-1.2beta5\src\java\org\apache\log4j\chains > aw\ControlPanel.java:41: > > >constructor length is > > > 166 lines (max allowed is 150). > > >[checkstyle] Audit done. > > > > > >BUILD FAILED > > > > > >C:\home\cgu\ASF\jakarta-log4j-1.2beta5\build.xml:236: Got 1 errors. > > > > > >Total time: 1 second > > > > > >I'll fix this! :-) > > > > > > > > >-- > > >Ceki > > >My link of the month: http://java.sun.com/aboutJava/standardization/ > > > > > > > > >-- > > >To unsubscribe, > e-mail: <mailto:[EMAIL PROTECTED]> > > >For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > > > > > > -- > > Ceki > > > > My link of the month: http://java.sun.com/aboutJava/standardization/ > > > > > > -- > > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > >-- >To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> >For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- Ceki My link of the month: http://java.sun.com/aboutJava/standardization/ -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
