Ceki,
Somehow, I missed your reply.
Sorry I haven't sent the changed files as attachments previously.
I've been working away from the office for the past two days, and haven't had much play with my email config at home.
I've attached the changed files to this email
I haven't found a Windows program that provides unified diffs, but I haven't yet spent much time looking.
BTW, I plan on creating and running the performance tests tonight, or at latest tomorrow.
And thanks for the words of encouragement. I've subscribed to all three log4j lists, so I saw that the change went into 1.2.4, but the public acknowledgment does boost the ego.
I have a comment on the associated test case, but I'm not sure what the correct forum is.
Since I have now brought it up, I would also add a test case where there is text preceding the CDATA section but no text following; a second test case where there is text following the CDATA section but no text preceding; and a third test case where there is only the CDATA section (i.e. Boundary Condition tests).
The test added to CVS tests the case where text precedes and follows the CDATA section.
I would provide examples, but I'm unsure of the filters you are using, though I'm sure they allow the assertTrue to make sense.
Mike McAngus
Associate Chief Engineer
Wendy's International
Knowledge Management
614-764-6776
From: Ceki Gülcü [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, June 12, 2002 9:17 AM
To: Log4J Developers List
Subject: Re: Updating millisecond timestamps.
At 07:08 12.06.2002 -0400, you wrote:
>Cakalic, James wrote:
>
>>Michael McAngus wrote:
>>
>>>>The code I submitted defaults to the comma, and it uses only the
>>>>decimal separators that are returned by java.text.DecimalFormatSymbols >>>>(currently comma and period).
>>
>>OK. And is that configurable so that one can choose the separator
>>independent of current locale?
>
>No.
That makes sense: there is not much space for options in a conversion
character.
I still would like to see the changes as attachments.
By the way, your CDATA patch to XMLLayout has been applied and will
become available in 1.2.4. Good patch. Thanks.
--
Ceki
SUICIDE BOMBING - A CRIME AGAINST HUMANITY
Sign the petition: http://www.petitiononline.com/1234567b
I am signatory number 22106. What is your number?
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
<font size="1">Confidentiality Warning: This e-mail contains information intended only for the use of the individual or entity named above. If the reader of this e-mail is not the intended recipient or the employee or agent responsible for delivering it to the intended recipient, any dissemination, publication or copying of this e-mail is strictly prohibited. The sender does not accept any responsibility for any loss, disruption or damage to your data or computer system that may occur while using data contained in, or transmitted with, this e-mail. If you have received this e-mail in error, please immediately notify us by return e-mail. Thank you.
AbsoluteTimeDateFormat.java
Description: Binary data
DateTimeDateFormat.java
Description: Binary data
ISO8601DateFormat.java
Description: Binary data
LogFileParser.java
Description: Binary data
FilteredLogTableModel.java
Description: Binary data
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
