[EMAIL PROTECTED] wrote:
>>1. I've added @t[timezone id], @l[language code], and @c[country
>>code] suboptions. Are there any other suboptions that people want?
>>
>
>I would make a generic method if PatternParser that will take a source
>string and a target suboption character. This method would then search the
>string for @<suboption char> and return the value of the suboption if
>defined in the source string and null or an empty string if not. That way
>this functionality can be reused for any option if needed in the future.
>Maybe you already did it this way.
>
But of course ;-)
>
>
>>2. I've add @d[decimal separator character]. Should this suboption
>>allow any character, or only decimal separators that are recognized by
>>java.text.DecimalFormat?
>>
>
>I would limit it to separators recognized by DecimalFormat.
>
Unless someone objects, I'll limit the decimal separator to those
recognized by DecimalFormat.
>>3. Based on Mark Womack's statement in
>><[EMAIL PROTECTED]> of this
>>thread, I have deprecated the constructors that take TimeZone parameters
>>in AbsoluteTimeDateFormat and its subclasses. I've also modified
>>DateLayout which seems to be the only class in the Log4J 1.2.4 project
>>which uses those constructors. Is this OK, or should I leave those
>>constructors, and DateLayout, unchanged?
>>
>
>As long as it is deprecated and not removed. Don't want the api to change.
>
Of course it's deprecated, and not removed!
>>4. Based on what I've seen in LF5, I added a %T option to
>>PatternLayout. This option logs the millisecond timestamp. This should
>>remove the need for LF5 to parse the %d{DATE} string when it displays
>>log file contents. Is this acceptable? Should the option be %R instead
>>(since the timestamp is Relative to midnight January 1, 1970 UTC)?
>>
>
>I have no opinion on this. Sounds useful though.
>
The more I think about it, the better I like %R. So, unless there are
objections....
>And thanks, Mike!
>
>-Mark
>
You're welcome, Mark.
--Mike
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
