DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12983>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12983

setFile(String filename, boolean appender) removed from super class

           Summary: setFile(String filename, boolean appender) removed from
                    super class
           Product: Log4j
           Version: 1.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Appender
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


The CompositeRollingAppender and DailyFileAppender each have a compile error 
in the setFile(String filename, boolean appender) method. Each calls its super 
class, FileAppender, with the following snippet of code:

          super.setFile(fileName, append);

After version 1.1.3 of Log4j, the FileAppender.setFile(String filename, 
boolean appender) was changed to FileAppender.setFile(String filename, boolean 
appender, boolean bufferedIO, int bufferSize). It appears that some of the sub-
classes of FileAppender haven't yet adopted this change but still call the non-
existant method resutling in the compile error.

Other classes that subclass FileAppender (DailyRollingFileAppender, 
RollingFileAppender, and ExternallyRolledFileAppender) appear to have adopted 
the 4 argument setFile method and do not provide for a two argument setFile 
method at all.

To fix, my recommendation is to change CompositeRollingAppender and 
DailyFileAppender to offer the 4 argument method and remove the two argument 
method. While deprecating the two argument method might be considered less 
intrusive to existing code that may be using this, no code can successfully 
invoke the 2 argument method without resulting in a runtime exception.

Thanks.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to