Hi, I've made the necessary changes to have LogFactor5 running on Xinerama without spanning over all screens on startup.
The problem with this patch is it's dependency on a JDK 1.4 API created just to solve this problem. I'm sending the patch which I would like to see included in the main trunk, but however, LogFactor5/Log4J must run on JDK 1.2... So, my question is: Is there any infrastructure on Log4J's build process to include or exclude code based on the Java Compiler or Ant Flags ? This patch has a relatively minor value, but if someone plans to use a new API like Java NIO what's the best way to implement this without breaking compatibility? Thanks, Luis Reis
Index: src/java/org/apache/log4j/lf5/LF5Appender.java =================================================================== RCS file: /home/cvspublic/jakarta-log4j/src/java/org/apache/log4j/lf5/LF5Appender.java,v retrieving revision 1.2 diff -u -r1.2 LF5Appender.java --- src/java/org/apache/log4j/lf5/LF5Appender.java 9 Oct 2002 22:50:03 -0000 1.2 +++ src/java/org/apache/log4j/lf5/LF5Appender.java 12 Jan 2003 03:26:31 -0000 @@ -220,7 +220,7 @@ */ protected static int getScreenWidth() { try { - return Toolkit.getDefaultToolkit().getScreenSize().width; + return GraphicsEnvironment.getLocalGraphicsEnvironment().getMaximumWindowBounds().width; } catch (Throwable t) { return 800; } @@ -233,7 +233,7 @@ */ protected static int getScreenHeight() { try { - return Toolkit.getDefaultToolkit().getScreenSize().height; + return GraphicsEnvironment.getLocalGraphicsEnvironment().getMaximumWindowBounds().height; } catch (Throwable t) { return 600; } Index: src/java/org/apache/log4j/lf5/util/LogMonitorAdapter.java =================================================================== RCS file: /home/cvspublic/jakarta-log4j/src/java/org/apache/log4j/lf5/util/LogMonitorAdapter.java,v retrieving revision 1.1 diff -u -r1.1 LogMonitorAdapter.java --- src/java/org/apache/log4j/lf5/util/LogMonitorAdapter.java 26 Apr 2002 15:48:42 -0000 1.1 +++ src/java/org/apache/log4j/lf5/util/LogMonitorAdapter.java 12 Jan 2003 03:26:31 -0000 @@ -243,7 +243,7 @@ */ protected static int getScreenWidth() { try { - return Toolkit.getDefaultToolkit().getScreenSize().width; + return GraphicsEnvironment.getLocalGraphicsEnvironment().getMaximumWindowBounds().width; } catch (Throwable t) { return 800; } @@ -256,7 +256,7 @@ */ protected static int getScreenHeight() { try { - return Toolkit.getDefaultToolkit().getScreenSize().height; + return GraphicsEnvironment.getLocalGraphicsEnvironment().getMaximumWindowBounds().height; } catch (Throwable t) { return 600; } Index: src/java/org/apache/log4j/lf5/viewer/LogBrokerMonitor.java =================================================================== RCS file: /home/cvspublic/jakarta-log4j/src/java/org/apache/log4j/lf5/viewer/LogBrokerMonitor.java,v retrieving revision 1.2 diff -u -r1.2 LogBrokerMonitor.java --- src/java/org/apache/log4j/lf5/viewer/LogBrokerMonitor.java 9 Oct 2002 22:50:04 -0000 1.2 +++ src/java/org/apache/log4j/lf5/viewer/LogBrokerMonitor.java 12 Jan 2003 03:26:34 -0000 @@ -1363,11 +1363,11 @@ } protected void centerFrame(JFrame frame) { - Dimension screen = Toolkit.getDefaultToolkit().getScreenSize(); Dimension comp = frame.getSize(); + Point centerPoint = GraphicsEnvironment.getLocalGraphicsEnvironment().getCenterPoint(); - frame.setLocation(((screen.width - comp.width) / 2), - ((screen.height - comp.height) / 2)); + frame.setLocation(centerPoint.x - comp.width / 2, + centerPoint.y - comp.height / 2); }
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>