I realized that the checkstyle.properties was for the ant task, not the
checkstyle settings.

BUT, the 2.4 version of checkstyle has a completely different ant task, and
does need a properties file. :-)  I converted the old ant task to the new
one:

  <target name="checkstyle" depends="init">
    <taskdef resource="checkstyletask.properties"
             classpath="${checkstyle.jar}"/>

    <!-- by default checkstyle supports the Sun coding standard. -->
    <checkstyle properties="checkstyle.properties">
      <fileset dir="src/java/org/apache/log4j/chainsaw"
includes="**/*.java"/>
      <fileset dir="src/java/org/apache/log4j/plugins"
includes="**/*.java"/>
    </checkstyle>
  </target>

and specified the following properties:

checkstyle.lcurly.method=nlow
checkstyle.lcurly.type=nlow
checkstyle.lcurly.other=nlow
checkstyle.maxmethodlen=500
checkstyle.maxconstructorlen=500

I know my code does not conform to the strict settings, but now even the
chainsaw code gets checkstyle errors.

Oliver?

Maybe we should spend some time figuring out the set of checkstyle setting
we want to adopt.  I do like the idea of using it.

-Mark

> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Sent: Sunday, February 02, 2003 11:05 PM
> To: Log4J Developers List
> Subject: checkstyle.properties?
>
>
> I decided to take the plunge and get my code (filters, plugins) to conform
> to the checkstyle settings, only to find that the
> checkstyle.properties file
> does not appear to be checked into the log4j cvs.
>
> Oliver, Ceki, what properties file do you use for this?
>
> thanks,
> -Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to