Given that the existing JDBCAppender has other serious problems, I think fixing 14827 is a waste of time. In any case, I won't stand in your way.
The following patch is likely to fix the problem.
Index: src/java/org/apache/log4j/jdbc/JDBCAppender.java
===================================================================
RCS file: /home/cvs/jakarta-log4j/src/java/org/apache/log4j/jdbc/JDBCAppender.java,v
retrieving revision 1.6.2.2
diff -u -u -r1.6.2.2 JDBCAppender.java
--- src/java/org/apache/log4j/jdbc/JDBCAppender.java 12 Jun 2002 21:29:57 -0000 1.6.2.2
+++ src/java/org/apache/log4j/jdbc/JDBCAppender.java 18 Feb 2003 18:23:29 -0000
@@ -241,6 +241,7 @@
}
}
buffer.removeAll(removes);
+ removes.clear();
//buffer.clear();
}
At 10:06 18.02.2003 -0800, you wrote:
--What about 14827/16998? Even if we are not going to use this class long term, it does have a serious memory leak, discovered by several people. Whether we like it or not, this appender seems popular. I vote to fix it.-Mark > -----Original Message----- > From: Ceki Gülcü [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, February 18, 2003 8:58 AM > To: Log4J Developers List > Subject: RE: Possible 1.2.8 release > > > At 20:54 16.02.2003 -0800, you wrote: > >I did a quick review of open bugs. Besides the fix for > #12366, I think we > >should consider fixes for: > > > >14827/16998 - JDBCAppender memory leak. > > > > >11570/16170 - Null Pointer Exception in XMLLayout. > > Bugs 11570/16170 fixed. As well as 15599 reported by Scott Schram. > The EntityResolve bug was fixed some time ago. Unless there is an > objection, I will make a 1.2.8 release within the next few hours. > > Is there anything else? > > >I'll help with applying fixes if agreed. > > > >-Mark > > > > >-- > > Ceki > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Ceki
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
