Yep. It's next in line. -Mark
> -----Original Message----- > From: Nicko Cadell [mailto:[EMAIL PROTECTED] > Sent: Wednesday, March 26, 2003 1:15 AM > To: 'Log4J Developers List' > Subject: RE: DO NOT REPLY [Bug 18246] - Patch: Add more MDC > support to X > MLLayout and PatternLayout > > > As far as I can see the PatternLayout does not yet support > the LoggingEvent > properties. In fact none of the layouts use the > LoggingEvent.getProperty(key) or getPropertyKeySet(). Support > should be easy > to add by simply copying all the code in the PatternLayout and the > PatternParser that deals with the MDC and change MDC to Property. The > capital P pattern is available, i.e. %P and %P{key}, and > could be used for > this purpose. > > Nicko > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > Sent: 26 March 2003 06:36 > > To: [EMAIL PROTECTED] > > Subject: DO NOT REPLY [Bug 18246] - Patch: Add more MDC > > support to XMLLayout and PatternLayout > > > > > > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG > > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT > > <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18246>. > > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND > > INSERTED IN THE BUG DATABASE. > > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18246 > > Patch: Add more MDC support to XMLLayout and PatternLayout > > > > > > ------- Additional Comments From [EMAIL PROTECTED] 2003-03-26 06:35 > ------- These changes and test cases look good to me, and I > have committed > them to > cvs. A couple of issues to followup on: > > 1) I would prefer that XMLLayout not sort the MDC keys. The > appender needs > to > be as fast as possible, and sorting the MDC keys for each > output will affect > > performance. The test case should be modified to handle the > order of the > keys > possibly being different. Ceki might have an idea on how to > do this with > some > pattern matching support test code? > > 2) The order of the keys output for the PatternLayout and > helpers/PatternParser > test cases could be different for different jvm versions, > since the order of > > the keys is indeterminate. We'll see if this affects the > Gump build/tests. > > Again, Ceki might have some idea how to create a pattern > match version in > the > test case. > > I had to update the PatternParser_mdc witness file since the > %X changes > affected it (yes, the test cases worked!). I reviewed the > new output and > the > test case, verified the new output is correct, and checked in > a new witness > file. > > I will leave this bug open for now so tht we can deal with > the two issues. > Thanks for the changes, Paul. Well done. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
