I am in the process of making extensive changes to PatternLayout to make it more flexible. Notably, the conversion specifier can be any Java identifier instead of just a single character. It will also be possible to register new conversion patterns by simply declaring them instead of sub-classing PatternLayout. I'll have a look at your changes after PatternLayout changes are completed.
After a very very short peek at some of the recent commits, I have noticed that you do not have the habit of adding your name as an author to files where you have made a contribution.
In my opinion, anyone who has written more than 10 lines of code to a source file deserves to be added as an author to that file. The 10 lines limit is an upper bound. Longer contributions automatically qualify. Shorter contributions are also eligible in case they significantly improve the existing code. Removing any existing author's name without his or her consent is a major no-no. I can't think of a single case where an author tag can be removed without the consent of the author.
In short, new authors can be added easily but one must be extremely careful in removing them. Coming to your contributions, please feel free to add your name as an author to files where you have made a contribution. There are many such files. :-)
The same obviously applies to Scott.
At 02:19 PM 6/17/2003 +1000, Paul Smith wrote:
Hi Mark & Ceki(& everyone else),
I've started checking some mods to SocketReceiver into the sandbox. Would anyone mind taking a peek at what I've done, and provide any feedback?
What I'm attempting to do is provide a dialog box for Chainsaw that shows all the Receivers in a little hierarchy, and show each Receiver with any children, if they have any. e.g. for a Socket Receiver, show all the currently connected socket details with IP/hostname & port. (you can see this by starting up chainsaw and choosing the View->Show Receivers... menu item. )
I'd then like the user to be able to start/stop a specific plugin via the GUI, and either disconnect, or "pause" a Net-based receiver. Perhaps by setting some threshold for a Receiver? Could we have a Threshold on a receiver too, just like an Appender? This could be in addition (but just prior) to passing it through the localLogger's own threshold.
This pause option would be particularly handy, because currently Chainsaw only has a pause that is very late in the event reception cycle (just about as late as you can get), be nice to cut all that work off at the knees as early as possible and tell a specific Receiver, or even SocketNode to just "forgetaboutit", and then resume when you are interested in monitoring the events.
cheers,
Paul Smith
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Ceki For log4j documentation consider "The complete log4j manual" ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp
In the USA the log4j manual is carried by Softpro books. http://store.yahoo.com/softpro/2-9700369-0-8.html
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]