Paul, I wasn't picking on your choosing the name "Thresholdable". Sometimes I wonder about the whole "*able" thing for interfaces...:-)
Yeah, we can make the change to Receivers to implement Thresholdable. In fact, I already have. But, my connection to the apache server has gone down for some reason and I cannot check in the changes. I'll keep trying for a while. If not, I'll check them in tomorrow morning. And, this is not to say that a "pause" functionality is not useful at the plugin level. I am open to it. I could see pausing/suspending a watchdog plugin. I'm not sure we need an interface for it, but having some supporting methods in the plugin interface might still be useful. -Mark ----- Original Message ----- From: "Paul Smith" <[EMAIL PROTECTED]> To: "'Log4J Developers List'" <[EMAIL PROTECTED]> Sent: Sunday, June 22, 2003 10:56 PM Subject: RE: Latest Receiver/Plugin commits to sandbox > > OK. I think that exposing the threshold=off functionality as > > "pause" is > > more of a gui terminology thing. So, I am voting with my > > code to go with > > threshold. I will shortly check in a "Thresholdable" > > interface (ick, but it > > is better than IThreshold), similar to the one you suggest > > Paul. > > the only other name I could think of was "SupportsThreshold" or similar. > > I have > > changed set/getLevel to set/getThreshold. > > Yes, this is more appropriate. > > > set/getLevel and have Logger, AppenderSkeleton, and Reciever > > all implement > > the interface, but I don't know if we want to make that big > > of a change to > > the logger interface. AppenderSkeleton already has the > > methods (except that > > is uses Priority instead of Level). > > We can defer modifying non-Receiver class hierachies till later, but I'd > like Receiver to have it if we could. Since Receivers are new in 1.3 we > have a little more luxury to play with the signature don't we? > > thanks for the feedback, > > > Paul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
