> Sorry my previous message went off too quickly. > > Hi Mark, Paul, Scott, > > This commit was probably not necessary at all. What is the difference > between this XMLLayout and the one in log4j proper? Can we remove this > duplicate file?
In XMLLayout's case,I'm having a hard time finding the difference. Maybe I can just delete the sandbox one. Scott? Can you clarify here?
I am pretty sure the both versions are the same.
> Having duplicates lying around makes it quite difficult to maintain > the code. Now that both Scott and you have access to the log4j CVS > repository and not just the sandbox, I ask you please stop maintaining > duplicates in log4j and log4j-sandbox. Given that your enhancements to > chainsaw remain unchallenged, please also migrate chainsaw as well as > the new plugin, receiver code. > > Is that OK with everyone? Mark?
I'm certainly ok with that, probably the major classes in the Sandbox that you and Mark should review before this happens though are:
* SocketReceiver * SocketNode * SocketNodeEventListener * log4j.dtd
Regardless of what gets committed into log4j-proper, we can always revert if need be. That is one of the advantages of using a version control system. Event files that get removed by CVS actually go to the CVS attic, they can be resuscitated if need be.
Peer review can be performed independently of the location of the file. Having duplicates just increases the maintenance pain without any tangible advantages, AFAIT.
Since these are changes to classes that are already in 1.2.7 or earlier.
There are some new Appenders/Receivers in the sandbox, but since they will not have been used by many, if at all, they are probably safe to merge into the core.
Placing files in log4j-proper does not mean much as long as the files are not in the 1.3 distribution.
While we're here, could the Servlet and Selector stuff go into core now too? They look/sound very useful.
Good point. The selector is a priority item. I have not yet carefully studied the servlet code.
Paul
--
Ceki For log4j documentation consider "The complete log4j manual"
ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
