At 11:30 PM 8/24/2003 -0500, Jacob Kjome wrote:
Great stuff Aleksei! Very nice idea. Not sure why I didn't think of doing this before? Seems so natural in a servlet environment. I tested it out and it works perfectly :-)
One explanation is that
ServletContextListener is new to spec version 2.3. Retrieving the servlet context from a map by name remains a smart idea nonetheless.
I'd like to see this go into the log4j-sandbox. In my local repository, I have your classes set up like the following...
org.apache.log4j.appender.ServletContextLogAppender org.apache.log4j.servlet.ServletContextLogAppenderListener
Isn't o.a.l.appender too generic?
As you can see, I changed the package and the names of your classes to be a better fit for the log4j-sandbox. Let me know if you think they should be different.
If no one else has objects to these classes going into the log4j-sandbox, I'll check them in as-is. Let me know if any changes to packages, class names, or design are desired.
Please do. Thank you.
Oh, and should Aleksei get committer access to the log4j-sandbox so he can modify/update his contribution? There isn't any explanation of how to use this stuff in the Javadoc. The extra info he provided at the top of his email should probably be added to the Javadoc of these classes. Giving Aleksei committer access would allow him to add the appropriate documentation after this stuff has been committed without having to resubmit modifications.
It is still a bit too early to grant Aleksei committer access to the sand-box. Assuming Aleksei continues to contribute, then by all means...
Jake
-- Ceki For log4j documentation consider "The complete log4j manual" ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
