I've done the research, and it is as Scott said due to the change in
PluginRegistry by Mark to change over to the use of the
Plugin.isEquivalent(..) as opposed to the use of equals(..).

The PluginTestCase has a PluginTester inner class that has an overridden
equals method that does some logging output for use in the witness
comparison.  Since PluginRegistry does not use this method, it never
outputs the expected text.

I could either:

* modify the witness file to the new output
* modify PluginTestCase so that it overrides isEquivalent and tries to
do the same thing

I'd expect that the latter is more appropriate, but I thought I would
check with everyone else first.  Is it ok?

I'd still like to know why GUMP hasn't nagged us about this, according
to the CVS repo, this should have been failing since the change in
October.

cheers,

Paul

On Wed, 2003-12-10 at 07:52, Ceki GÃlcà wrote:
> This is from Scott.
> 
> >From: "Scott Deboy" <[EMAIL PROTECTED]>
> >To: Ceki GÃlcà <[EMAIL PROTECTED]>
> >
> >Found the culprit.
> >
> >I pulled 1.8 of PluginRegistry.java (instead of the tip - 1.9) and the 
> >Plugins tests run fine...so it was introduced with the latest commit that 
> >added the 'isEquivalent' code, but I'm not familiar enough with the plugin 
> >stuff to fix it..
> >
> >Hope this helps


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to