At 02:40 AM 12/10/2003 +0000, [EMAIL PROTECTED] wrote:
psmith 2003/12/09 18:40:47

  Modified:    src/java/org/apache/log4j/pattern PatternParser.java
  Added:       src/java/org/apache/log4j/pattern
                        PropertiesPatternConverter.java
  Log:
  Added a Properties pattern converter by
  basically copying the MDCPropertyPatternConverter
  by Ceki.

Last evening before leaving the office, I made a note to myself to remind me to solicit log4j-dev@ in order to add a PropertiesPatternConverter. Imagine my surprise this morning when I saw it just sitting in our CVS repository. :-)

There are days when everything just goes right. This maybe one of those.

  Since MDC uses the 'X', figured 'Y' was ok for properties,
  but also registered the word 'properties' as well.

Sorry for nitpicking but my preference would be to avoid introducing new conversion characters (i.e. single letter conversion words). Thus, although 'properties' is perfectly fine, 'Y' is probably less so. How about just 'properties'? What do you think?

--
Ceki Gülcü

For log4j documentation consider "The complete log4j manual"
ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to