On Mon, 23 Feb 2004, Mark Womack wrote: | Geir, | | Geez, I've been waiting for you to stand up and ask about the vote that was | promised at ApacheCon. | | All we need is someone to propose the changes to they can be reviewed (not | torn apart as Endre says) and voted on. The change should be backward | compatible.
Here is a suggestion. I might have fscked up on several places: *) I checked out cvs logging-log4j, not realizing that this is 1.3beta. Hopefully this patch can be applied to 1.2.7? *) I hadn't set my editor to -not- convert tabs to spaces, and it seems like you guys really love tabs (I CAN'T UNDERSTAND THAT!! TABS ARE EVIL!!!!). I diffed using --ignore-space-change, but still - wanna take a look? - it seems quite ok. What I did: In effect there was only three files to change, Priority, Level and Category. But in addition, I changed the Priority's _INT statics' values, as the trace level would have ended up on 0 if the 10000 step should be followed. Are they used for anything except for comparison? This might be a breakage of the "backwards compatible" requirement, if it is likely that anyone would use these numbers or constants outside of the "log4j proper". I added a set of SYSLOG_-ints, so that the number in the Level constructor isn't just a magic number. I changed all "Enumeration enum" throughout the code, since this is a reserved word in Java 1.5 - they are now called "Enumeration enumeration". I changed the sequence of code in Category - all the methods regarding the predefined levels are stacked at the bottom of the file, in fatal, error, warn, info, debug, trace order, with is*Enabled, *(Object) and *(Object t) as the "internal" order within a level - this made it a little easier to browse the file. Remeber that Javadocs initial list of methods are alphabethised, while the verbose part is in the order it appears in the file - it is thus favourable also for the JavaDoc, I believe. I removed som dead code (commented out) from Logger, Priority, Level and Category, having to do with a FINE level that's obviously not used - when using CVS: -remove- dead code, don't comment it out! Finally, i diffed using the following command: diff -ruN -x CVS --ignore-space-change logging-log4j-backup logging-log4j Are there any other places where the TRACE level have to be inserted, except for Priority, Level and Category? First diff ever submitted to you folks - don't kill me if things are totally off..! Endre. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
