Hi Ceki,
One comment on ContextJNDISelector. If I use InitShutdownController to set the repository selector and then do configuration, you will ultimately reset my configuration with the first call to getLoggerRepository(). First you attempt to use a URL to the file defined in JNDI under the name "java:comp/env/log4j/configuration-resource". If that is null, you attempt to load off the classloader. The latter step is problematic since I might not have a config file in the classpath, but there might be one in the server's classpath which isn't my own.
This probably a misunderstanding due to a documentation problem. The method for loading the config file has *not* changed. The search method is described in the javadocs for the Loader.getResource() method. (It is the same as in 1.2).
I updated the documentation in o.a.l.helpers.IntializationUtil
In fact, I usually keep mine in WEB-INF/config and let InitContextListener initialize it.
You can still do that.
This will stomp on my configuration, very likely with the wrong config file.
Why do you think so?
Furthermore, in the case that no config file is found, you the print "Could not find resources to perform automatic configuration.".
Indeed, a "Could not find..." message will be printed. Note that the behavior in 1.2 is exactly the same.
So, my configuration will either be reset or I will get an annoying message even though I've already configured my logger repository.
No resetting will occur.
Am I just tired and misinterpreting what ContextJNDISelector does, or is this behavior not quite right?
I fail to see a problem since the new code is generalization of the old. In 1.2 only the default repository could be automatically configured. In 1.3 any repository can using the same search algorithm as in 1.2 for the config files.
However, I am now testing the code to make sure that it works with multiple repositories. Will report back soon.
Jake
-- Ceki G�lc�
For log4j documentation consider "The complete log4j manual"
ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
