Thanks for the reply.
Looking at the CVS HEAD revisions I see that the bulk of the changes have already been made. And as Yoav Shapira pointed out in his reply log4j-1.2.8 is built to work with JDK 1.1 and ThreadLocal was introduced with JDK 1.2. So there it is. There's some minor cleanup to the CVS HEAD revision for NDC. Here's the diff:
<diff> 98,100d97 < static int pushCounter = 0; // the number of times push has been called < // after the latest call to lazyRemove < static final int REAP_THRESHOLD = 5; </diff>
Since these were used by the lazyRemove() method and that method has been removed since it isn't needed when using a ThreadLocal ivar, may as well clean up the clutter too.
= Ezra E.
Niclas Hedhman wrote:
On Thursday 28 October 2004 03:01, E. Epstein (ML) wrote:
So.... having not contributed to log4j before, what step next?
P.S., Since writing this I've gone ahead and changed NDC.java. It
compiles and passes basic tests. It is gzipped and attached here.
Generally, most Apache projects appreciates if the contributor submits a diff file, instead of the entire file. That can most of the time prevent changes made after your snapshot, being lost.
And you should generate the diff file against the CVS HEAD of the active branch, so first check out the CVS source, then issue for instance a
cvs -q diff -u NDC.java >NDC.diff
And send in the NDC.diff file.
Some projects (like Log4J) prefer to receive the diff files in the issue tracking system, as one can easier attach comments, like if it has been applied, and a discussion around the patch can be collected in one place.
Hope this helps you help the Log4J project.
Niclas
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
