Scott,

Thanks for these changes which more or less complete log4j's migration
to self-reliant logging. I've noticed that you have not yet taken
advantage of parameterizes messages. For example,

in ChainsawCyclicBufferTableModel instead of writing:

   logger.debug("Adding col '" + key + "', columNames=" + columnNames);

one could write

   logger.debug("Adding col '{}', columNames={}.", key, columnNames);

in PluginPropertyEditorPanel instead of writing:

 logger.debug("Cell value class " + valueClass +
                   " not know, using default editor");
one could write

logger.debug("Cell value class {} not known, using default editor", valueClass );

The parametirezed versions run 10 to 20 times faster when the logging
statements are disabled.

Note that the parametirezed printing methods require that the
parameters be Objects, not primitive types. The number of arguments is
limited to two but from my experience in migrating from LogLog to
logger, 95% of cases are covered with one or two arguments, but your
mileage may vary.

Cheers,


-- Ceki Gülcü

The complete log4j manual: http://qos.ch/eclm
Professional log4j support: http://qos.ch/log4jSupport




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to