The baseURI issue has nothing to do with URL vs InputStream. It is very XML protocol specific, and I don't think that any specific protocol issue should be propagated into a general interface like Configurator. Not unless you find a way to generally represent it and it makes sense to the general class/usage of Configurators.
The fact that I can get a InputStream from a URL/File but I cannot get a URL from an InputStream suggests, to me at least, which one is more "common". And as I have said, there are/will be many sources that cannot be represented as a URL. It says something that all of the current configurators, except PropertyConfigurator, already supported doConfigure(InputStream); I didn't have to make any changes to them when I added the method to Configurator. While the baseURI issue may be a big deal for the XML based configurators, I would view this suggested interface change as a patch. If there is no other way to deal with it, then maybe there should be a new interface, XMLConfigurator or something. Then only the XML specific configurators will be affected and very specific and useful methods can be devised. -Mark -----Original Message----- From: Ceki G�lc� [mailto:[EMAIL PROTECTED] Sent: Friday, December 10, 2004 2:46 AM To: Log4J Developers List Subject: Re: Make Configurators stateless again At 09:29 PM 12/9/2004, Curt Arnold wrote: >On Dec 9, 2004, at 12:32 AM, Mark Womack wrote: > >It looks like you were adding doConfigure(InputStream) methods to >something configurator related. Would you consider making it > >doConfigure(InputStream stream, String baseURI); > >where baseURI may be null and is ignored for non-XML configurators. An >XML document contains relative URI's can't be resolved without a baseURI >(source of the recent thread on involving log4j.dtd). Reverting Mark's change to the Configurator interface would be my first choice. As Curt's remarks demonstrate, InputStream is not a common *denominator* for files, URLs. -- Ceki G�lc� The complete log4j manual: http://qos.ch/log4j/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
