cvs commit: logging-log4j/src/java/org/apache/log4j/net TelnetAppender.java

[ceki]

ceki        2004/12/15 13:01:02

  Modified:    src/java/org/apache/log4j/net TelnetAppender.java
  Log:
  A logger which knows itself to be in an erroneous state should not log
  within its append() method as this would generate a log message each
  time append() is called.
  
  Revision  Changes    Path
  1.9       +6 -6      
logging-log4j/src/java/org/apache/log4j/net/TelnetAppender.java
  
  Index: TelnetAppender.java
  ===================================================================
  RCS file: 
/home/cvs/logging-log4j/src/java/org/apache/log4j/net/TelnetAppender.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- TelnetAppender.java       15 Dec 2004 15:39:11 -0000      1.8
  +++ TelnetAppender.java       15 Dec 2004 21:01:02 -0000      1.9
  @@ -72,8 +72,9 @@
       try {
         sh = new SocketHandler(port);
         sh.start();
  -    } catch (Exception e) {
  -        getLogger().error("Could not active TelnetAppender options: ", e);
  +    } catch (IOException e) {
  +      getLogger().error("Could not active TelnetAppender options for 
TelnetAppender named "+getName(), e);
  +      throw new IllegalStateException("Could not create a SocketHandler for 
TelnetAppender named "+getName());
       }
     }
   
  @@ -95,10 +96,9 @@
     /** Handles a log event.  For this appender, that means writing the
       message to each connected client.  */
     protected void append(LoggingEvent event) {
  -      if(sh == null) {
  -          getLogger().warn("SocketHandler is null, not sending event.");
  -          return;
  -      }
  +    if(sh == null) {
  +      return;
  +    }
   
       sh.send(this.layout.format(event));
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]