Hi Scott, I think that your change is, indeed, consistent with the rest of the build. However, I think the entire logic of this is flawed. It allows for the generation of an incomplete log4j.jar (as you mentioned) and that just shouldn't be allowed. If there are compile-time dependencies, they should be mandatory. At runtime, if one doesn't use some of the features that require extra dependencies, then they are optional. But the build should never allow them to be optional. All or none.
Jake Quoting Scott Deboy <[EMAIL PROTECTED]>: > I'm a bit confused. > > In the current build script: > > If JavaMail is missing from the classpath, the build doesn't compile > SMTPAppender - and creates a log4j jar without SMTPAppender. Also, the > person compiling isn't notified that SMTPAppender won't be included in the > jar. > > The JMS dependency has the same effect on JMSAppender - JMSAppender is not > compiled but the log4j jar is still created. > > My change to exclude ORO-dependent classes seemed to follow this same pattern > - create a chainsaw jar without the ORO-dependent classes. > > I'm not sure what I need to change in order to treat the ORO dependency the > same as we do mail and jms. From my point of view, my change to the build is > consistent with how we handle the other non-fatal but missing dependencies > (everything except jndi). > > Would you like me to change the build so that a missing ORO jar prevents > compilation or creation of log4j or chainsaw jars? If so, should we do the > same for the other dependencies (jms, mail, etc.)? > > > > Scott > > > > > -----Original Message----- > From: Ceki Gülcü [mailto:[EMAIL PROTECTED] > Sent: Thu 12/16/2004 9:09 AM > To: Log4J Developers List > Cc: > Subject: RE: cvs commit: logging-log4j build.xml > At 05:53 PM 12/16/2004, Scott Deboy wrote: > > >A few more thoughts: > > > >You can't tell by the jar name that it doesn't include the ORO dependencies. > > and likely to cause avoidable confusion down the road. > > >For this reason, if it was a concern I'd be +0 on reverting the ant script > >changes, but I'd like to leave the changes to RuleFactory. > > Having given this a little more thought. With or without the changes, the > build can be considered broken. I think it makes sense to explicitly add a > ORO dependency when building log4j.jar, in the same way it has a dependency > on mail.jar or jms.jar. > > Scott, would you do the honors? > > > -- > Ceki Gülcü > > The complete log4j manual: http://qos.ch/log4j/ > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
