Hi Curt,
At 07:15 PM 12/23/2004, Ceki G�lc� wrote:
At 06:59 PM 12/23/2004, you wrote:That seems to be substantially upping the complexity of CachedDateFormat. It seemed a lot simpler to protect against that weakness by checking for it DatePatternConverter. Something like:
try { if (pattern.indexOf("S") == -1 || pattern.indexOf("SSS") != -1) { df = new CachedDateFormat(SimpleDateFormat(pattern)); } else { df = new SimpleDateFormat(pattern); }
} catch (IllegalArgumentException e) {
In unlikely case where the pattern contains quoted 'S' characters the (pattern.indexOf("S") == -1 || pattern.indexOf("SSS") != -1) will be unsafe.
Also, the slot stuff also seemed to up the complexity. I was trying to make it simpler at some trival cost (an extra dateformat per second or so) and still avoid the migrating millisecond field problem, I thought that I had adequately addressed that weakness.
Indeed, maybe you have adequately addressed the migrating millisecond field problem. I have to look at the code again. (I was not fully aware of the migrating millisecond field problem encountered with 1 or 2 'S' when I started making changes.) Let me look at your latest version again and come back to you.
-- Ceki G�lc�
The complete log4j manual: http://qos.ch/log4j/
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
