At 04:34 PM 1/8/2005, Curt Arnold wrote:
logging-log4j is currently failing due to Gump expecting the "jar" target to prepare both a log4j.jar and a chainsaw.jar target when due to recent changes it only produces a log4j.jar target. I've got a series of changes that should get Gump back online which I will commit if there are no objections.
Basically, the changes do:
Restore the "jar" target to build both log4j.jar and log4j-chainsaw.jar. If you just want to build log4j.jar, you can use the "log4j.jar" target.
I committed exactly the same change a few hours ago.
Change the Gump description of logging-log4j to run the "log4j.jar" target and only expect log4j.jar, change the name of the "log4j-tests" project to "logging-log4j-tests" and add a new project "logging-log4j-chainsaw" that builds chainsaw.jar.
+1.
Remove the dependency of the "log4j.jar" target on "build.chainsaw" and "build.examples" by introducing a "build.log4j" target. Those targets don't contribute classes to log4j.jar and it would be good that any breakage in chainsaw or the examples, not break applications that depend just on log4j.jar.
+1
Add "build.examples" as a dependency to the "regression" target in tests/build.xml. Maybe there is a better place for this, but it isolates dependent projects from breakages in the examples, but still compiles them as a "test" of the API.
build.examples is no longer a dependency of tests/build.xml. So there is no need to modify ./tests/build.xml.
Index: build.xml
===================================================================
RCS file: /home/cvs/logging-log4j/build.xml,v
retrieving revision 1.134
diff -r1.134 build.xml
194,195c194,195
< <target name="build" description="Compile all log4j components."
< depends="init, build.core, build.examples,
---
> <target name="build.log4j" description="Compile log4j, but not chainsaw or examples."
> depends="init, build.core,
197c197,201
< build.servletAPI, build.db, build.oro, build.chainsaw"/>
---
> build.servletAPI, build.db, build.oro"/>
>
>
> <target name="build" description="Compile all log4j components."
> depends="build.log4j, build.examples, build.chainsaw"/>
362c366
< <!-- Aactual work is done in the dependencies.
-->
---
> <!-- Actual work is done in the dependencies.
-->
370c374
< <target name="log4j.jar" depends="build">
---
> <target name="log4j.jar" depends="build.log4j">
Index: tests/build.xml
===================================================================
RCS file: /home/cvs/logging-log4j/tests/build.xml,v
retrieving revision 1.89
diff -r1.89 build.xml
121a122
> <ant dir=".." target="build.examples" inheritRefs="true"/>
=================================================================== RCS file: /home/cvs/gump/project/logging-log4j.xml,v retrieving revision 1.11 diff -r1.11 logging-log4j.xml 3c3 < Copyright 2004 The Apache Software Foundation --- > Copyright 2004-2005 The Apache Software Foundation 33c33 < <ant target="jar"> --- > <ant target="log4j.jar"> 49,50d48 < <!--jar name="log4j-lf5-@@DATE@@.jar" id="lf5"/--> < <jar name="log4j-chainsaw-@@DATE@@.jar" id="chainsaw"/> 56c54 < <project name="log4j-tests"> --- > <project name="logging-log4j-tests"> 76a75,101 > > <project name="logging-log4j-chainsaw"> > <package>org.apache.log4j.chainsaw</package> > > <ant target="chainsaw.jar"> > <property name="version" value="@@DATE@@"/> > </ant> > > <depend project="ant" inherit="runtime"/> > <depend project="xml-apis"/> > <depend project="xml-xerces"/> > <depend project="jakarta-oro"/> > <depend project="logging-log4j" /> > > <work nested="classes"/> > <option project="jakarta-servletapi-4"/> > <option project="jms"/> > <option project="jmx"/> > <option project="junit"/> > <option project="javamail"/> > > <jar name="log4j-chainsaw-@@DATE@@.jar" id="chainsaw"/> > > <nag to="log4j-dev@logging.apache.org" > from="<[EMAIL PROTECTED]>"/> > </project> >
-- Ceki Gülcü
The complete log4j manual: http://www.qos.ch/log4j/
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
