Hi Curt,
As long as the test for stripDuplicateBackslashes exists and gets executed frequently, then I think the details should be left to the player doing the footwork -- that means you in this case.
If you are in addition saying that the many of the test in log4j are too coarse-grained, then I agree. It would be really nice if we could devise smaller tests. I'd appreciate your input on this matter.
At 12:46 AM 2/12/2005, Curt Arnold wrote:
After porting the backslash stripping code back to log4cxx, I decided that I liked the stripDuplicateBackslashes better on FileAppender (where it is in log4cxx) than in OptionConverter and started to move it in my working copy of log4j. However, I ran into the problem of not having a good home for the associated unit tests and abandoned that effort.
Unfortunately, I was coerced into doing a good thing when I unintentionally committed my modified FileAppender when removing DBAppender2. At that point, I was compelled to remove the duplicate code from OptionConverter (I reverted it back to v 1.51) and change the unit test code in OptionSubstitutionTest to point to the new home in FileAppender.
I would have loved to move the unit test from OptionSubstitutionTest to a more appropriate home (for example, FileAppenderTestCase where it lives in the log4cxx test suite), however there does not seem to be a good home for simple unit tests. All the test targets in the ant build appear to be related to some functional aspect of log4j. Did I miss something or how about an "internal" test suite and associated ant target that would be the home for these types of tests.
-- Ceki G�lc�
The complete log4j manual: http://www.qos.ch/log4j/
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
