carnold     2005/02/22 12:25:32

  Modified:    src/java/org/apache/log4j Appender.java
               tests/src/java/org/apache/log4j AbstractAppenderTest.java
  Log:
  Reverting Appender interface change
  
  Revision  Changes    Path
  1.18      +0 -22     logging-log4j/src/java/org/apache/log4j/Appender.java
  
  Index: Appender.java
  ===================================================================
  RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/Appender.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- Appender.java     18 Feb 2005 17:23:44 -0000      1.17
  +++ Appender.java     22 Feb 2005 20:25:32 -0000      1.18
  @@ -29,12 +29,6 @@
    * @author Ceki Gülcü
    */
   public interface Appender extends Component {
  -  
  -  /**
  -   * An appender must be activated before it can be used.
  -   */
  -  public void activate();
  -  
     /**
      * Add a filter to the end of the filter list.
      *
  @@ -71,22 +65,6 @@
      */
     public void close();
   
  -  
  -  /**
  -   * Is this appender closed?
  -   *
  -   * @since 1.3
  -   */
  -  public boolean isClosed();
  -
  -  /**
  -   * Is this appender in working order?
  -   *
  -   * @since 1.3
  -   */
  -  public boolean isActive();
  -  
  -  
     /**
      * Log in <code>Appender</code> specific way. When appropriate, Loggers 
will
      * call the <code>doAppend</code> method of appender implementations in
  
  
  
  1.4       +7 -8      
logging-log4j/tests/src/java/org/apache/log4j/AbstractAppenderTest.java
  
  Index: AbstractAppenderTest.java
  ===================================================================
  RCS file: 
/home/cvs/logging-log4j/tests/src/java/org/apache/log4j/AbstractAppenderTest.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- AbstractAppenderTest.java 21 Feb 2005 23:34:41 -0000      1.3
  +++ AbstractAppenderTest.java 22 Feb 2005 20:25:32 -0000      1.4
  @@ -18,7 +18,6 @@
   
   import java.io.Writer;
   
  -import org.apache.log4j.net.SMTPAppenderTest;
   import org.apache.log4j.spi.LoggingEvent;
   
   import junit.framework.Test;
  @@ -46,21 +45,21 @@
     public void testNewAppender() {
       // new appenders whould be inactive
       Appender appender = getAppender();
  -    assertFalse(appender.isActive());
  -    assertFalse(appender.isClosed());
  +//    assertFalse(appender.isActive());
  +//    assertFalse(appender.isClosed());
   
       appender.close();
  -    assertTrue(appender.isClosed());
  +//    assertTrue(appender.isClosed());
     }
   
     public void testConfiguredAppender() {
       Appender appender = getConfiguredAppender();
  -    appender.activate();
  -    assertTrue(appender.isActive());
  -    assertFalse(appender.isClosed());
  +//    appender.activate();
  +//    assertTrue(appender.isActive());
  +//    assertFalse(appender.isClosed());
   
       appender.close();
  -    assertTrue(appender.isClosed());
  +//    assertTrue(appender.isClosed());
     }
   
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to