At 02:19 AM 2/26/2005, Curt Arnold wrote:
On Feb 25, 2005, at 6:57 PM, Paul Smith wrote:
Appender the interface is the contract for all Appenders, AppenderSkeleton just happens to provide some decent plumbing and support in an effort to make it easy to write a custom appender.
Anywhere within log4j we should think Appender, and forget about the existence of AppenderSkeleton. Changing the contract of the interface should be done with extreme caution.
However, if changing the contract is for good reasons, then I am in favour of it, as long as we provide good documentation about "Why my custom appender doesn't work in 1.3" in big bold flashing lights.
Paul
At the present, I don't think the proposed changes to Appender are justified or beneficial. They are not used within log4j itself, they are only used within a new test case (AbstractAppenderTest) that could have been written in terms of AppenderSkeleton since it tests details of the AppenderSkeleton implementation that have not been part of the Appender contract.
People,
I can't get work done without having it reverted a few days later. In the last few days, I started working on improving the Appender interface in preparation for a much larger body of improvements. Unfortunately, the work got stalled. Now, there are complaints voiced about the newly introduced methods in Appender not being useful. Of course they are not useful as I did not get a chance to complete the work I started.
We have to put a stop for this type of continuos haggling. We have work to do and it won't get done if we politicize every little detail. These frequency of these debates is approaching the level of the intolerable.
I would like to ask the log4j committers to grant me the freedom to improve the way appenders work and to consolidate their lifecycle into something well defined and robust.
Do I have your support in this endeavor?
-- Ceki Gülcü
The complete log4j manual: http://www.qos.ch/log4j/
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
