On Mar 13, 2005, at 10:15 AM, Boris Unckel wrote:
Hello,
the new methods to allow an object to be inserted in an message is a very
good extension to the existing methods.
I want to send a few suggestions/requirements and hope that you comment on
them:
1) There is the capability to insert 1 or 2 objects in an message.
I think to insert 1 object is a method for ease of use and there
should be an method for unlimited objects (Like Object[] args).
You could pass a List or an Array type as the message parameter. The case isn't widely enough used to justify additional methods on the logger classes, at least not yet.
2) The method for 2 objects: public void error(String messagePattern, Object arg1, Object arg2)... starts with an String for the message pattern. The method for 1 object: public void error(Object messagePattern, Object arg)... starts with an object message pattern instead of an String and checks with instanceof that the message pattern is an string.
Both methods should have the similar signature with String.
Again, I don't think the justification is there for these additional signatures at this time.
3) There ist no support for I18N in the Logger and the Factories.
International projects and software (which are very common) whould heavily
profit to have an internal support with J2SE standard mechanism for I18N in
Logging messages, naturally with message formatter capabilities combined.
Actually, there are some very decent reasons why a resource bundle based approach may not be the most appropriate for diagnostic logging. I have previously implemented localizing layout which translate messages before appending which have worked well. There was a thread on this topic back in December 2004 on [email protected] (http://article.gmane.org/gmane.comp.jakarta.commons.devel/59103/ match=arnold+enterprise)
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
