On May 7, 2005, at 6:15 PM, Claudio Corsi wrote:
Curt,
I noticed that you removed the protected closeWriter method. This need to be included because these streams should not be closed.
They aren't. SystemOutStream.close does not call down to System.out.close.
I also wanted to point out that you only need a single reference of SystemErrStream and SystemOutStream. I would recommend that instead of creating new SystemErrStream and SystemOutStream instances make them final static attributes instead. For instance,
If there were going to be a lot of instances of ConsoleAppender then singletons would be beneficial. But I can't come up with scenarios where you would have substantially more than one ConsoleAppender, and I think the current code is simpler and better for the 0 and 1 ConsoleAppenders cases and ties at 2.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
