DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34981>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34981

           Summary: suspicion of wrong argument passed to Windows API
                    function
           Product: Log4j
           Version: 1.2
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Appender
        AssignedTo: [email protected]
        ReportedBy: [EMAIL PROTECTED]


I was enhancing the nteventlog.cpp file, the source of the native library
NTEventLogAppender.dll. I noticed following call in function regSetString:

RegSetValueEx(hkey, name, 0, REG_SZ, (LPBYTE)value, lstrlen(value));

Though it doesn't produce any error (for the present :-), it is IMHO in
contradiction with MSDN documentation, where following is said:

"If the data is of type REG_SZ, REG_EXPAND_SZ, or REG_MULTI_SZ, cbData must
include the size of the terminating null character or characters."
(http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/base/regsetvalueex.asp)

So the correct call should be
RegSetValueEx(hkey, name, 0, REG_SZ, (LPBYTE)value, lstrlen(value) + 1);

Thanks

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to