On Jul 22, 2005, at 4:23 PM, Mark Womack wrote:

OK, so do we see that making this change does not affect performance? This change uses any String object, not the shared intern() version AND it uses
String.equals() since it no longer depends on a the single intern()
reference.

And we should test the performance in different JDK's.


The bug report contains benchmarks of the change on JDK 1.4 on Mac, JDK 1.2 on Win 98SE and JDK 1.5 on Win XP. In all tested platforms, the change was beneficial both in reducing the time required for the creation of new loggers by avoiding the String.intern call which appears to be responsible for approx 30% of the total cost of creating a new logger and in subsequent retrieval since String.equals appears (surprisingly) to be faster than ==. I assume that you could find JDK 1.1 or other implementations where the old code was faster.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to