On Jul 27, 2005, at 10:08 PM, Mark Womack wrote:
For the bugs that have been marked as "1.2.12 candidate" that are
still open, here is the current review:
14551, 17227, 18122, 30804, 30819 are Javadoc related.
24159 - declined, will not be fixed for 1.2.12.
26345 - may be too dangerous, need to review some more. Opinions?
Probably not a difficult fix, but easy to make big mistake if you
don't know what you are doing and I don't.
31727 - declined, don't know what I was thinking.
33624 - I will be looking at this.
Go Mark Go.
34026 - I think we should still fix this. Opinions?
Go Mark Go.
If I am not mistaken, we still need to test serialization with the
new TRACE level added? If so, then I can write a bug on it.
I ported the serialization tests from log4j 1.3 back to the log4j 1.2
branch (Bug 26433) a few weeks ago before adding TRACE. Adding trace
(and the other changes) did not break the tests which makes me feel
relatively comfortable that none of the changes have broken
serialization. I did not add any of the unit test bugs to docs/
HISTORY.txt since the tests are not in the distribution.
From a code review, I believe that an older Chainsaw will not
recognized the TRACE_LEVEL in the serialized LoggingEvent but will
map it to Level.DEBUG which seems like reasonable behavior. However,
it would be good if somebody could do a sanity check and fire up
Chainsaw and see if it works okay.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
