On Jul 29, 2005, at 11:43 AM, Curt Arnold wrote:


On Jul 29, 2005, at 9:16 AM, Jacob Kjome wrote:

Of course, we could release a modified version of the DTD in Log4j-1.2.12 with
the "name" attribute not declared as of type "id".  Thoughts?


Using a type ID for name was not a good choice, but I don't think we can change it. If anybody was using the log4j.dtd in a different context, they possibly could have depended on the ID-ness of name since there are certain DOM methods (Document.getElementById for example) that would behave differently if the type was changed.

I think the safer approach is to modify the error handler so a validation error is treated as a warning. So in this case, you might see an warning from the XML parser that the name is not valid according to the DTD, but things would still work. Turning off validation entirely (effectively what the JoranConfigurator did) would be another option.


Looking at the 1.2 code it appears that it already tries to just warn the user if it encounters a validation error. Is there a problem (other than a warning) that appears when there is non-ID value used for the name?

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to