log4j 1.2.12 proposal

Curt Arnold Mon, 15 Aug 2005 22:08:22 -0700

The best option that I've found is to Jikes which doesn't appear totrigger the annoying warning when running on earlier JVM's. Jikesdid have a problem with a class implementing an interface method thathad been marked deprecated, so in the following patch, the@deprecation on LoggerRepository.getCurrentCategories was downgradedto a comment. The changes to LoggingReceiver workaround thecompilation problem with JDK 1.2 javac, but isn't essential. Thechanges to tests/build.xml (which is not distributed with log4j) ishelpful for testing on earlier JVM's since many of the tests fail dueto stack trace and serialization differences between JVM's and it ishelpful to run all the tests (by specifying -Dhaltonfailure=no)instead of stopping at the first one.


To build using Jikes:


Download jikes-1.22-1.windows.zip, unzip and place on path.

ant -Dbuild.compiler=jikes -Dlogging-site=... dist



Index: src/java/org/apache/log4j/chainsaw/LoggingReceiver.java
===================================================================

RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/chainsaw/Attic/LoggingReceiver.java,v

retrieving revision 1.2.2.2
diff -u -r1.2.2.2 LoggingReceiver.java

--- src/java/org/apache/log4j/chainsaw/LoggingReceiver.java 24 May2005 05:06:18 -0000 1.2.2.2+++ src/java/org/apache/log4j/chainsaw/LoggingReceiver.java 16 Aug2005 04:53:43 -0000

@@ -40,17 +40,21 @@
      *
      * @author <a href="mailto:[EMAIL PROTECTED]">Oliver Burn</a>
      */
-    private class Slurper implements Runnable {
+    private static class Slurper implements Runnable {
         /** socket connection to read events from **/
         private final Socket mClient;
+        /** where to put the events **/
+        private final MyTableModel mModel;
+
         /**
          * Creates a new <code>Slurper</code> instance.
          *
          * @param aClient socket to receive events from
          */
-        Slurper(Socket aClient) {
+        Slurper(Socket aClient, MyTableModel aModel) {
             mClient = aClient;
+            mModel = aModel;
         }
         /** loops getting the events **/
@@ -82,10 +86,10 @@
     }
     /** where to put the events **/
-    private final MyTableModel mModel;
+    private MyTableModel mModel;
     /** server for listening for connections **/
-    private final ServerSocket mSvrSock;
+    private ServerSocket mSvrSock;
     /**
      * Creates a new <code>LoggingReceiver</code> instance.
@@ -109,7 +113,7 @@
                 final Socket client = mSvrSock.accept();
                 LOG.debug("Got a connection from " +
                           client.getInetAddress().getHostName());
-                final Thread t = new Thread(new Slurper(client));

+ final Thread t = new Thread(new Slurper(client,mModel));

                 t.setDaemon(true);
                 t.start();
             }
Index: src/java/org/apache/log4j/spi/LoggerRepository.java
===================================================================

RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/spi/LoggerRepository.java,v

retrieving revision 1.9.2.2
diff -u -r1.9.2.2 LoggerRepository.java

--- src/java/org/apache/log4j/spi/LoggerRepository.java 24 May2005 05:06:21 -0000 1.9.2.2+++ src/java/org/apache/log4j/spi/LoggerRepository.java 16 Aug2005 04:53:43 -0000

@@ -89,7 +89,8 @@
   Enumeration getCurrentLoggers();
   /**
-     @deprecated Please use [EMAIL PROTECTED] #getCurrentLoggers} instead.  */

+ * Gets an enumeration of categories. Please use [EMAIL PROTECTED]#getCurrentLoggers} instead.

+   */
   public
   Enumeration getCurrentCategories();
Index: tests/build.xml
===================================================================
RCS file: /home/cvs/logging-log4j/tests/build.xml,v
retrieving revision 1.16.2.10
diff -u -r1.16.2.10 build.xml
--- tests/build.xml    22 Jul 2005 20:09:23 -0000    1.16.2.10
+++ tests/build.xml    16 Aug 2005 04:53:43 -0000
@@ -23,6 +23,7 @@
   <property name="tests.source.home" value="./src/java/"/>
   <property name="excludes" value=""/>
+  <property name="haltonfailure" value="yes"/>
   <path id="tests.classpath">
     <pathelement location="${project.source.home}"/>
@@ -135,7 +136,7 @@

     <target name="Core" depends="build">
-      <junit printsummary="yes" fork="yes" haltonfailure="yes">