I set up my environment to use jdk 1.3.1_16 and all of the jars listed in the new build.properties.sample. I did a build locally (rc4+) and then diff'd the result with Curt's rc4.

Only differences of note (beyond the javadoc timestamps) were:

1) The build.xml changes to fix the jmx issue Curt found after building his rc4.

2) Some linefeed differences in the example java files.

3) And a difference in the CategoryKey.java file around the fix applied to remove the String.intern() call. I believe that my current version from cvs is the correct version. Not sure what was up with your version, Curt?

diff -r logging-log4j-1.2.12rc4/src/java/org/apache/log4j/CategoryKey.java logging-log4j-1.2.12rc4+/src/java/org/apache/log4j/CategoryKey.java
20c20,21
< CategoryKey is heavily used internally to accelerate hash table searches.
---
   CategoryKey is a wrapper for String that apparently accellerated
   hash table lookup in early JVM's.
29c30
<     this.name = name.intern();
---
    this.name = name;
46c47
<       return  name == ((CategoryKey)rArg ).name;
---
      return  name.equals(((CategoryKey)rArg ).name);

I would say that we are good to go for an rc5 (and hopefully last rc for the 1.2.12 release).

-Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to