DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38024>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38024





------- Additional Comments From [EMAIL PROTECTED]  2005-12-29 01:13 -------
There are several issues that are addressed in rev 359667.

1. Change to signature of abstract format method in Layout:

The signature of the abstract format method was changed from

String format(LoggingEvent event) 

to

void format(Writer output, LoggingEvent event) throws IOException

and the original method was provided by delegating to the new method.

While it would be good to redesign the class to have a Writer, StringBuilder or
StringBuffer as a parameter in 2.0, the only appender that directly used the new
signature was SyslogAppender and the Layout implementations had not been
modified to eliminate use of their static StringBuffers.  Basically, then only
thing that had changed is they had an output.write(sbuf.toString()) at the end.

Since the benefits of the changed signature had not been realized and the change
would break user provided layouts, it seemed best to revert to the 1.2 
signature.

2. HTMLLayout had been moved to org.apache.log4j.html

This patch restores its previous package name.

3. o.a.l.helpers.DateLayout had been collapsed into o.a.l.TTCCLayout

This patch restores DateLayout (from the current TTCCLayout code) which could
have been used as a base class for user supplied layouts.  Both DateLayout and
TTCCLayout are marked as deprecated.

The only remaining Layout related incompatibility is with the
PatternLayout.createPatternParser which could have been overriden in derviatives
of PatternLayout to introduce custom format specifiers.  The implementation of
PatternLayout in 1.3 appears to be so significantly changed that restoring that
capability may be difficult.

All recently added unit tests from the 1.2 branch were ported with only minor
changes.  The MyPatternParser and MyPatternLayout tests which use the lost
PatternLayout.createPatternParser method were not ported.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to