o.a.l.DefaultCategoryFactory was removed from log4j 1.3 in this patch. Since this class existed in log4j 1.2.x, removing it breaks compatibility with any application that used it. It has to go back, though it could be marked as deprecated. Since the class was not declared as public, is effectively just an bad obsolete name and in my opinion not worth this disruption to deprecate it and replace it with DefaultLoggerFactory.

The rename of Hierarchy.defaultFactory to Hierarchy.loggerFactory seemed unnecessary and makes it harder to compare log4j 1.2 with log4j 1.3. However, it is not a binary compatibility issue as the member was declared private.

tests/input/xml/loggerFactory1.xml hints that you may have written a org.apache.log4j.xml.LoggerFactoryTest, however that class did not appear in the commit. As it stands, there is only an input file for a test, not an effective test.

If you have tests that use those input files, please commit them. Once they are in, then I think we could restore DefaultCategoryFactory and Hierarchy.defaultFactory, remove DefaultLoggerFactory and consider back porting the changes to log4j 1.2.



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to