On Apr 24, 2007, at 10:35 AM, Curt Arnold wrote:
On Apr 24, 2007, at 1:57 AM, Paul Smith wrote:
A new constructor was added to LocationInfo for 1.2.15, but it
doesn't quite work properly. The other get*() methods use the
fullInfo field to calculate values, but the new constructor
effectively sets them.
I fell down on that one. I can't believe that I didn't write any
unit tests or mark the method as @since 1.2.15.
As for the patch, I think it is safer to try to compensate in the
new constructor for the old behavior instead of the other way
around. I have a rewrite of the constructor that will build the
fullinfo so that the getClass() et al methods would work as they
are. I'll commit when I have got the tests in place.
The parameter order could be a bit improved. It mixes up the
logical location (class, method) fragments with the physical
location (file, line) fragments. I'll review it and possibly
switch the order to class, method, file, line. Unfortunately,
there would be no signature change so we have to make sure that we
fix all the existing uses of the constructor.
Committed change rev 531995 The parameter order was set several
years ago in log4j 1.3. Can't change it.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
